yandrey321 commented on code in PR #9770:
URL: https://github.com/apache/ozone/pull/9770#discussion_r2809841097


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/RocksDbPersistentMap.java:
##########
@@ -165,16 +161,26 @@ public V setValue(V value) {
       }
 
       @Override
-      public void close() {
-        iterator.close();
-        readOptions.close();
-        if (upperBoundSlice != null) {
-          upperBoundSlice.close();
-        }
-        if (lowerBoundSlice != null) {
-          lowerBoundSlice.close();
-        }
+    public void close() {
+      iterator.close();
+      readOptions.close();
+      if (upperBoundSlice != null) {
+        upperBoundSlice.close();
+      }
+      if (lowerBoundSlice != null) {
+        lowerBoundSlice.close();
       }
-    };
+    }
+  };
+}
+
+  private RocksDBException toRocks(Exception e) {

Review Comment:
   code duplication, should be moved to the Utility class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to