yandrey321 commented on code in PR #9770:
URL: https://github.com/apache/ozone/pull/9770#discussion_r2809842637
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/RocksDbPersistentSet.java:
##########
@@ -76,15 +75,24 @@ public E next() {
try {
return codecRegistry.asObject(rawKey, entryType);
} catch (IOException exception) {
- // TODO: [SNAPSHOT] Fail gracefully.
- throw new RuntimeException(exception);
+ throw SnapshotStorageException.fromIO("deserialize set entry",
exception);
}
}
@Override
- public void close() {
- managedRocksIterator.close();
- }
- };
+ public void close() {
+ managedRocksIterator.close();
+ }
+ };
+}
+
+ private RocksDBException toRocks(Exception e) {
Review Comment:
duplicated code, should be moved to the utility class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
