ChenSammi commented on a change in pull request #2278:
URL: https://github.com/apache/ozone/pull/2278#discussion_r643624294
##########
File path: hadoop-hdds/interface-admin/src/main/proto/ScmAdminProtocol.proto
##########
@@ -445,6 +454,32 @@ message GetContainerTokenResponseProto {
required TokenProto token = 1;
}
+message StartContainerBalancerRequestProto {
+ optional string traceID = 1;
+ required double threshold = 2;
Review comment:
Do all these required fileds have default values? If so, they are
optional, insteal of required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]