JacksonYao287 commented on a change in pull request #2278:
URL: https://github.com/apache/ozone/pull/2278#discussion_r642340854
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/protocol/StorageContainerLocationProtocolServerSideTranslatorPB.java
##########
@@ -611,6 +638,28 @@ public ReplicationManagerStatusResponseProto
getReplicationManagerStatus(
.setIsRunning(impl.getReplicationManagerStatus()).build();
}
+ public StartContainerBalancerResponseProto startContainerBalancer(
+ StartContainerBalancerRequestProto request)
+ throws IOException {
+ impl.startContainerBalancer();
+ return StartContainerBalancerResponseProto.newBuilder().build();
+ }
Review comment:
i see the conversion
[here](https://github.com/apache/ozone/pull/2230#discussion_r639555281), which
mentioned that balance configuration will not be needed. should we add it back？
maybe we could keep it like this for now , and add it back if needed as we move
forward with the implementation. what do you think @lokeshj1703
@siddhantsangwan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
