vyalamar commented on PR #9771: URL: https://github.com/apache/ozone/pull/9771#issuecomment-4020084934
Addressed the review feedback in the current branch:\n- removed the shutdown hook and rely on normal S3G stop/unregister flow\n- cached the metrics-enabled config decision\n- fixed the missing `OzoneConfiguration` import in `TestS3GatewayMetrics`\n- added config-aware test coverage for enabled/disabled behavior\n- kept the disabled path runtime-safe by avoiding source registration rather than returning a null metrics instance\n\nValidation:\n`mvn -pl hadoop-ozone/s3gateway -am -Dtest=TestS3GatewayMetrics -Dsurefire.failIfNoSpecifiedTests=false test`\npasses locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
