ChenSammi commented on code in PR #8843:
URL: https://github.com/apache/ozone/pull/8843#discussion_r2915827798
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -404,6 +407,16 @@ public class DatanodeConfiguration extends
ReconfigurableConfig {
)
private Duration diskCheckTimeout = DISK_CHECK_TIMEOUT_DEFAULT;
+ @Config(key = "hdds.datanode.disk.check.sliding.window.timeout",
+ defaultValue = "60m",
+ type = ConfigType.TIME,
+ tags = {ConfigTag.DATANODE},
+ description = "Time interval after which a disk check"
+ + " failure result stored in the sliding window will expire."
+ + " Unit could be defined with postfix (ns,ms,s,m,h,d)."
+ )
+ private Duration diskCheckSlidingWindowTimeout =
DISK_CHECK_SLIDING_WINDOW_TIMEOUT_DEFAULT;
Review Comment:
What's the recommendation of value relationship between this new property
and PERIODIC_DISK_CHECK_INTERVAL_MINUTES_DEFAULT? Say if user reconfigured
PERIODIC_DISK_CHECK_INTERVAL_MINUTES_DEFAULT to 2h, or 30m, shall we suggest
user to reconfigure this property too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
