adoroszlai commented on code in PR #9950:
URL: https://github.com/apache/ozone/pull/9950#discussion_r2958874311
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java:
##########
@@ -337,9 +337,9 @@ public void failVolume(String volumeRoot) {
failedVolumeMap.put(volumeRoot, volume);
volumeHealthMetrics.decrementHealthyVolumes();
volumeHealthMetrics.incrementFailedVolumes();
- LOG.info("Moving Volume : {} to failed Volumes", volumeRoot);
+ LOG.error("Moving Volume : {} to failed Volumes", volumeRoot);
Review Comment:
This is not an error. Callers of `failVolume` log at higher level.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java:
##########
@@ -632,7 +632,7 @@ private void closeDbStore() {
DatanodeStoreCache.getInstance().removeDB(containerDBPath);
dbLoaded.set(false);
dbLoadFailure.set(false);
- LOG.info("SchemaV3 db is stopped at {} for volume {}", containerDBPath,
+ LOG.warn("SchemaV3 db is stopped at {} for volume {}", containerDBPath,
Review Comment:
`closeDbStore()` is executed in normal shutdown, too, so this shouldn't be a
warning. For failure case, warning is logged in callers of `failVolume`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
