errose28 commented on code in PR #9950:
URL: https://github.com/apache/ozone/pull/9950#discussion_r2978101850
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java:
##########
Review Comment:
I think anything resulting a failed volume check should be logged at the
error level. There are two such cases in `HddsVolume#check` that we can elevate
from `warn` to `error`.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java:
##########
@@ -648,7 +648,7 @@ public void compactDb() {
volumeInfoMetrics.dbCompactTimesNanoSecondsIncr(
Time.monotonicNowNanos() - start);
} catch (Exception e) {
- LOG.warn("compact rocksdb error in {}", dbFilePath, e);
+ LOG.error("compact rocksdb error in {}", dbFilePath, e);
Review Comment:
This could just be a transient IO error, which happens sometimes. Since we
don't act on the failure I think the original warning level makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
