szetszwo commented on code in PR #9953: URL: https://github.com/apache/ozone/pull/9953#discussion_r3004161399
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/AbstractContainerSafeModeRule.java: ########## @@ -50,13 +56,43 @@ public abstract class AbstractContainerSafeModeRule extends SafeModeExitRule<Nod private final double safeModeCutoff; private final AtomicInteger totalContainers = new AtomicInteger(); private final AtomicInteger containersWithMinReplicas = new AtomicInteger(); + private final Map<ContainerID, ContainerID> openContainers = new ConcurrentHashMap<>(); + private final Map<ContainerID, ContainerID> closedContainers = new ConcurrentHashMap<>(); + private final Map<ContainerID, ContainerID> processedContainers = new ConcurrentHashMap<>(); Review Comment: @sadanand48 , thanks for the update! If we refresh the safemode rules every 5s, do we still need the new maps? They do make the code complicated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
