szetszwo commented on code in PR #9953:
URL: https://github.com/apache/ozone/pull/9953#discussion_r3059590816
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/SafeModeExitRule.java:
##########
@@ -68,6 +68,10 @@ public String getRuleName() {
return ruleName;
}
+ protected final SCMSafeModeManager getSafeModeManager() {
+ return safeModeManager;
+ }
+
Review Comment:
This new method is unused. Please remove it.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/SCMSafeModeManager.java:
##########
@@ -133,6 +164,10 @@ public SafeModeMetrics getSafeModeMetrics() {
return safeModeMetrics;
}
+ public boolean isPeriodicRefreshEnabled() {
+ return refreshIntervalMs > 0;
+ }
+
Review Comment:
This new method is unused. Please remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
