sodonnel commented on code in PR #10011:
URL: https://github.com/apache/ozone/pull/10011#discussion_r3015566595
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -426,6 +426,13 @@ message UpgradeFinalizationStatus {
repeated string messages = 2;
}
+message UpgradeStatus {
+ required bool scmFinalized = 1;
+ required int32 numDatanodesFinalized = 2;
+ required int32 numDatanodesTotal = 3;
+ required bool shouldFinalize = 4;
Review Comment:
This is a new object - shouldn't all its fields be required as we have no
backward compatibility issue here - nothing else can be using this object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
