adoroszlai commented on code in PR #10011:
URL: https://github.com/apache/ozone/pull/10011#discussion_r3015757710
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -426,6 +426,13 @@ message UpgradeFinalizationStatus {
repeated string messages = 2;
}
+message UpgradeStatus {
+ required bool scmFinalized = 1;
+ required int32 numDatanodesFinalized = 2;
+ required int32 numDatanodesTotal = 3;
+ required bool shouldFinalize = 4;
Review Comment:
It's about backward compatibility of a future version of the software. From
the docs I linked:
> `required` must not be used for new fields. Semantics for required fields
should be implemented at the application layer instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
