peterxcli commented on code in PR #9815:
URL: https://github.com/apache/ozone/pull/9815#discussion_r3017185075
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1176,6 +1185,11 @@ message KeyInfo {
// This allows a key to be created an committed atomically if the original
has not
// been modified.
optional uint64 expectedDataGeneration = 22;
+
+ // expectedETag, when set, indicates that the existing key must have
+ // the given ETag for the operation to succeed. This is used for
+ // S3 conditional writes with the If-Match header.
+ optional string expectedETag = 23;
Review Comment:
good point. let's refactor the `expectedDataGeneration` and `expectedETag`
into another dedicated proto message as follow-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
