adoroszlai commented on code in PR #10058:
URL: https://github.com/apache/ozone/pull/10058#discussion_r3056215549
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/ListInfoSubcommand.java:
##########
@@ -65,6 +66,11 @@ public class ListInfoSubcommand extends ScmSubcommand {
defaultValue = "false")
private boolean json;
+ @CommandLine.Option(names = {"--failed-volumes"},
+ description = "Only show datanodes that have at least one failed
volume.",
Review Comment:
`--show-failed-volumes` implies failed volumes are normally hidden, and
included in the output only if this flag is used.
I think the command
```
ozone admin datanode list --with-failed-volume
```
reads better.
If we want to be extra clear, it can be `--nodes-with-failed-volume`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
