sreejasahithi commented on code in PR #10058:
URL: https://github.com/apache/ozone/pull/10058#discussion_r3061968797


##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/ListInfoSubcommand.java:
##########
@@ -65,6 +65,11 @@ public class ListInfoSubcommand extends ScmSubcommand {
        defaultValue = "false")
   private boolean json;
 
+  @CommandLine.Option(names = {"--nodes-with-failed-volumes"},
+      description = "Only show datanodes that have at least one failed 
volume.",
+      defaultValue = "false")
+  private boolean nodeWithFailedVolumes;
+

Review Comment:
   The --nodes-with-failed-volumes filter is silently ignored when --node-id is 
used.
   We should make these options mutually exclusive to avoid confusion when a 
user provides both in the command but receives the result for the node whose ID 
was specified, regardless of whether it has failed volumes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to