peterxcli commented on PR #10164: URL: https://github.com/apache/ozone/pull/10164#issuecomment-4368048437
> Hi @peterxcli > We need to set them null for now, otherwise, they'll be stored in KeyTable later, which we don't want. > Once we've completed #10181, setting them to null will no longer be necessary, as the codec will prevent them from being stored in the KeyTable. yeah, for the key commit request, your statement is true, but I'm asking if `S3MultipartUploadCompleteRequest` we touched need to do the same thing. - https://github.com/apache/ozone/blob/bbf16876544531e6423c548e125653cac1bca1f9/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java#L310-L312 - https://github.com/apache/ozone/blob/bbf16876544531e6423c548e125653cac1bca1f9/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestWithFSO.java#L249-L250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
