YutaLin commented on PR #10164:
URL: https://github.com/apache/ozone/pull/10164#issuecomment-4368352373

   Hi @peterxcli,
   In `S3MultipartUploadCompleteRequest`, we don't have to do that because 
those fields are not set in `OpenKeyTable` during the mpu process. We validate 
conditional resource(keyArgs) against the existing Keyinfo from the `KeyTable`.
   
https://github.com/apache/ozone/blob/329bc8166826ee4f2a1d1609919cb26c36999d3b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCompleteRequest.java#L456
   
   For put requests, however, the conditional resource comes from the 
OpenKeyTable. Since it may already contain conditional values when stored, we 
need to set them to null beforehand.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to