peterxcli commented on PR #10207:
URL: https://github.com/apache/ozone/pull/10207#issuecomment-4411317553
> > @YutaLin I think this patch only handle the read side condition check,
but we also need dest side:
> > > Destination Object Conditions (AWS Release 2.37.0):
> > > If-None-Match: "*" - Copy only if destination does NOT exist Prevents
unintended overwrites of destination object
> > > Error Codes: 412 Precondition Failed - When any condition is not met
>
> Hi @peterxcli, the conditional read side check is `ObjectEndPoint`
#copyObject -> writeConditions is passed to the #copy-> #openKeyForPut is
called with writeConditions -> #openKeyForPut applies If-None-Match, If-Match
>
> Let me know if I miss anything, thanks!
thanks for explanation, then I think only thing remain is the test coverage
for them.
I saw the copy request builder has following we should use the cover the
write part in sdk v2:
```java
public final String ifMatch() {
return this.ifMatch;
}
public final String ifNoneMatch() {
return this.ifNoneMatch;
}
```
v1 also need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
