YutaLin commented on PR #10207:
URL: https://github.com/apache/ozone/pull/10207#issuecomment-4411655565

   > thanks for explanation, then I think only thing remain is the test 
coverage for them.
   > 
   > I saw the copy request builder has following we should use the cover the 
write part in sdk v2:
   > 
   > ```java
   > public final String ifMatch() {
   >   return this.ifMatch;
   > }
   > 
   > public final String ifNoneMatch() {
   >   return this.ifNoneMatch;
   > }
   > ```
   > 
   > v1 also need
   
   Hi @peterxcli
   I've add tests in sdkv2. I don't add it in v1 because it doesn't support 
destination conditions for CopyObject. Only v2 has ifMatch/IfNoneMatch method.
   sources:
   
https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/s3/model/CopyObjectRequest.html
   
   CI: https://github.com/YutaLin/ozone/actions/runs/25591732427


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to