JacksonYao287 commented on a change in pull request #2278:
URL: https://github.com/apache/ozone/pull/2278#discussion_r651415720
##########
File path:
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStartSubcommand.java
##########
@@ -39,7 +39,12 @@
private double threshold;
@Option(names = {"-i", "--idleiterations"},
- description = "Maximum consecutive idle iterations")
+ description = "Maximum consecutive idle iterations",
+ //idleiteration could be as follows:
+ // 0 ： indicate running infinitely
+ // positive number ： indicate the specific iterations
+ // -1 : user does not set this value
+ defaultValue = "-1")
Review comment:
i think it would be a little complex to use optional here , since we
just need to avoid an input idleiteration with 0 and this can be implemented by
a simple judgement. what is more, optional is usually used to handle null(maybe
not 0 or some other special values), so i think it is better not to use
optional here, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
