JacksonYao287 commented on a change in pull request #2278:
URL: https://github.com/apache/ozone/pull/2278#discussion_r651487148
##########
File path:
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStartSubcommand.java
##########
@@ -39,7 +39,12 @@
private double threshold;
@Option(names = {"-i", "--idleiterations"},
- description = "Maximum consecutive idle iterations")
+ description = "Maximum consecutive idle iterations",
+ //idleiteration could be as follows:
+ // 0 ： indicate running infinitely
+ // positive number ： indicate the specific iterations
+ // -1 : user does not set this value
+ defaultValue = "-1")
Review comment:
yes, this is indeed a problem, which i tried to assign a default value
to solve it, but missed in the lastest commit. i see the doc
[here](https://picocli.info/#_optionalt), i think here we should use an
optional as you said. thanks, i will update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
