ArafatKhan2198 commented on code in PR #10198:
URL: https://github.com/apache/ozone/pull/10198#discussion_r3215045407
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerEndpoint.java:
##########
@@ -812,4 +818,54 @@ public Response getOmContainersDeletedInSCM(
response.put("containerDiscrepancyInfo", containerDiscrepancyInfoList);
return Response.ok(response).build();
}
+
+ /**
+ * Return all containers in QUASI_CLOSED state.
+ *
+ * @param limit max no. of containers to get.
+ * @param prevKey the containerID after which results are returned.
+ * @return {@link Response}
+ */
+ @GET
+ @Path("/quasiClosed")
+ public Response getQuasiClosedContainers(
+ @DefaultValue(DEFAULT_FETCH_COUNT) @QueryParam(RECON_QUERY_LIMIT) int
limit,
+ @DefaultValue(PREV_CONTAINER_ID_DEFAULT_VALUE)
@QueryParam(RECON_QUERY_PREVKEY) long prevKey) {
+
+ List<ContainerInfo> containers = containerManager.getContainers(
+ ContainerID.valueOf(prevKey + 1), limit,
HddsProtos.LifeCycleState.QUASI_CLOSED);
+
+ List<UnhealthyContainerMetadata> metaList = containers.stream()
+ .map(ci -> {
+ long containerID = ci.getContainerID();
+ int requiredNodes = 0;
+ try {
+ requiredNodes = ci.getReplicationConfig().getRequiredNodes();
+ } catch (Exception e) {
+ LOG.warn("Could not get required nodes for container {}",
containerID, e);
+ }
+ List<ContainerHistory> replicas =
containerManager.getLatestContainerHistory(containerID, requiredNodes);
+
+ UnhealthyContainerMetadata metadata = new UnhealthyContainerMetadata(
Review Comment:
*Fixed. Created a dedicated `QuasiClosedContainerMetadata` DTO with
semantically correct fields (`stateEnterTime`, `expectedReplicaCount`,
`actualReplicaCount`, `pipelineID`, `keys`, `replicas`). Updated
`QuasiClosedContainersResponse` to use `List<QuasiClosedContainerMetadata>` and
removed the temporary extra constructor that was added to
`UnhealthyContainerMetadata`. The frontend types are also updated with a
separate `QuasiClosedContainer` type.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
