sodonnel commented on code in PR #10236:
URL: https://github.com/apache/ozone/pull/10236#discussion_r3317284425
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1900,6 +1908,10 @@ public void start() throws IOException {
bootstrap(omNodeDetails);
}
+ if (omUpgradeFinalizeService != null) {
Review Comment:
No, this is not temporary. The service is created in the code like this only
if finalization is needed:
```
if (versionManager.needsFinalization()) {
long intervalMs =
conf.getTimeDuration(OMConfigKeys.OZONE_OM_UPGRADE_FINALIZATION_CHECK_INTERVAL,
OMConfigKeys.OZONE_OM_UPGRADE_FINALIZATION_CHECK_INTERVAL_DEFAULT,
TimeUnit.MILLISECONDS);
omUpgradeFinalizeService = new OMUpgradeFinalizeService(this,
versionManager, getScmClient(), intervalMs);
}
```
And then it is started. It will check periodically if the should finalize
key has been set which will be set by the upcoming client command PR. Once
finalize is completed the service shuts itself down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
