adoroszlai commented on code in PR #9915:
URL: https://github.com/apache/ozone/pull/9915#discussion_r3319512100
##########
pom.xml:
##########
@@ -515,6 +569,26 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-anthropic</artifactId>
+ <version>0.36.2</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-core</artifactId>
+ <version>0.36.2</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-google-ai-gemini</artifactId>
+ <version>0.36.2</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-open-ai</artifactId>
+ <version>0.36.2</version>
+ </dependency>
Review Comment:
> every other third-party library in the project follows this same pattern
of individual version entries. Introducing a BOM import for just this one
library would be inconsistent with how the rest of the project is structured.
1. BOM import has been in use for quite some time now, so please do switch
to `langchain4j-bom`:
https://github.com/apache/ozone/blob/cfb8adea488da08a56f75acf46011574325482aa/pom.xml#L229-L327
2. Even if BOM is not available for some dependency, please define a
property for consistent versioning of multi-module dependency, example:
https://github.com/apache/ozone/blob/cfb8adea488da08a56f75acf46011574325482aa/pom.xml#L517-L526
##########
hadoop-ozone/recon/pom.xml:
##########
@@ -62,6 +62,22 @@
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
</dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-anthropic</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-core</artifactId>
+ </dependency>
Review Comment:
```
Jar files under share/ozone/lib in the build have changed.
Please update:
* hadoop-ozone/dist/src/main/license/bin/LICENSE.txt
(add new dependencies with the appropriate license, delete any removed
dependencies)
* hadoop-ozone/dist/src/main/license/jar-report.txt
(based on the diff shown below)
If you notice unexpected differences (can happen when the check is run in a
fork), please first update your branch from upstream master to get any other
recent dependency changes.
If you are running this locally after build with -DskipShade, please ignore
any
ozone-filesystem jars reported to be missing.
Changes detected:
--- /dev/fd/63 2026-05-27 10:02:54.566056827 +0000
+++ /dev/fd/62 2026-05-27 10:02:54.566056827 +0000
@@ -35,6 +35,7 @@
share/ozone/lib/commons-pool2.jar
share/ozone/lib/commons-text.jar
share/ozone/lib/commons-validator.jar
+share/ozone/lib/converter-jackson.jar
share/ozone/lib/curator-client.jar
share/ozone/lib/curator-framework.jar
share/ozone/lib/derby.jar
@@ -158,6 +159,7 @@
share/ozone/lib/jsp-api.jar
share/ozone/lib/jspecify.jar
share/ozone/lib/jsr311-api.jar
+share/ozone/lib/jtokkit.jar
share/ozone/lib/kerb-core.jar
share/ozone/lib/kerb-crypto.jar
share/ozone/lib/kerb-util.jar
@@ -165,7 +167,14 @@
share/ozone/lib/kerby-config.jar
share/ozone/lib/kerby-pkix.jar
share/ozone/lib/kerby-util.jar
+share/ozone/lib/kotlin-stdlib-common.jar
+share/ozone/lib/kotlin-stdlib-jdk7.jar
+share/ozone/lib/kotlin-stdlib-jdk8.jar
share/ozone/lib/kotlin-stdlib.jar
+share/ozone/lib/langchain4j-anthropic.jar
+share/ozone/lib/langchain4j-core.jar
+share/ozone/lib/langchain4j-google-ai-gemini.jar
+share/ozone/lib/langchain4j-open-ai.jar
share/ozone/lib/listenablefuture-empty-to-avoid-conflict-with-guava.jar
share/ozone/lib/log4j-api.jar
share/ozone/lib/log4j-core.jar
@@ -193,7 +202,11 @@
share/ozone/lib/netty-transport.Final.jar
share/ozone/lib/nimbus-jose-jwt.jar
share/ozone/lib/okhttp-jvm.jar
+share/ozone/lib/okhttp-sse.jar
+share/ozone/lib/okhttp.jar
share/ozone/lib/okio-jvm.jar
+share/ozone/lib/okio.jar
+share/ozone/lib/openai4j.jar
share/ozone/lib/opentelemetry-api.jar
share/ozone/lib/opentelemetry-common.jar
share/ozone/lib/opentelemetry-context.jar
@@ -259,6 +272,7 @@
share/ozone/lib/re2j.jar
share/ozone/lib/reflections.jar
share/ozone/lib/reload4j.jar
+share/ozone/lib/retrofit.jar
share/ozone/lib/rocksdb-checkpoint-differ.jar
share/ozone/lib/rocksdbjni.jar
share/ozone/lib/simpleclient.jar
```
https://github.com/ArafatKhan2198/ozone/actions/runs/26503992485/job/78053259617#step:13:18
##########
hadoop-ozone/recon/src/main/resources/chatbot/recon-fallback-prompt-template.txt:
##########
Review Comment:
```
Files with unapproved licenses:
/home/runner/work/ozone/ozone/hadoop-ozone/recon/src/main/resources/chatbot/recon-summarization-prompt.txt
/home/runner/work/ozone/ozone/hadoop-ozone/recon/src/main/resources/chatbot/recon-fallback-prompt-template.txt
/home/runner/work/ozone/ozone/hadoop-ozone/recon/src/main/resources/chatbot/recon-api-guide.md
/home/runner/work/ozone/ozone/hadoop-ozone/recon/src/main/resources/chatbot/recon-tool-selection-prompt-preamble.txt
```
##########
pom.xml:
##########
@@ -569,6 +569,26 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-anthropic</artifactId>
+ <version>0.36.2</version>
+ </dependency>
+ <dependency>
+ <groupId>dev.langchain4j</groupId>
+ <artifactId>langchain4j-core</artifactId>
+ <version>0.36.2</version>
Review Comment:
This does not work with Java 8.
```
Error: bad class file:
/home/runner/.m2/repository/dev/langchain4j/langchain4j-core/0.36.2/langchain4j-core-0.36.2.jar(dev/langchain4j/data/message/AiMessage.class)
Error: class file has wrong version 61.0, should be 52.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
