szetszwo commented on code in PR #10405:
URL: https://github.com/apache/ozone/pull/10405#discussion_r3342985050
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeID.java:
##########
@@ -45,7 +45,7 @@ private DatanodeID(final UUID uuid) {
}
// Mainly used for JSON conversion
- public String getID() {
+ public String getUuid() {
Review Comment:
@navinko , Thanks for the update! Let's rename it to
`getUuidStringForTesting()` and move it right after toString().
```diff
@@ -70,6 +65,10 @@ public String toString() {
return uuidByteString.getString();
}
+ public String getUuidStringForTesting() {
+ return toString();
+ }
+
/**
* This will be removed once the proto structure is refactored
* to remove deprecated fields.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
