szetszwo commented on code in PR #10405:
URL: https://github.com/apache/ozone/pull/10405#discussion_r3352709271


##########
hadoop-ozone/dist/src/main/smoketest/balancer/testBalancer.robot:
##########
@@ -160,7 +160,7 @@ Get All Container IDs
 
 Get Datanode Ozone Used Bytes Info
     [arguments]             ${uuid}
-    ${output} =    Execute    export DATANODES=$(ozone admin datanode list 
--json) && for datanode in $(echo "$\{DATANODES\}" | jq -r '.[].id'); do ozone 
admin datanode usageinfo --uuid=$\{datanode\} --json | jq 
'{(.[0].datanodeDetails.id.uuid) : .[0].ozoneUsed}'; done | jq -s add
+    ${output} =    Execute    export DATANODES=$(ozone admin datanode list 
--json) && for datanode in $(echo "$\{DATANODES\}" | jq -r '.[].id'); do ozone 
admin datanode usageinfo --uuid=$\{datanode\} --json | jq 
'{(.[0].datanodeDetails.uuidString) : .[0].ozoneUsed}'; done | jq -s add

Review Comment:
   @navinko , thanks a lot for the detailed analysis!  
   
   If we keep DatanodeID.getUuid(), could the robot test pass?
   
   How about we change getUuid() to return String instead of UUID?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to