kerneltime commented on PR #10488:
URL: https://github.com/apache/ozone/pull/10488#issuecomment-4761478123
Thanks @szetszwo. Addressed the three concrete comments in the latest push
(also rebased on master to clear the `OzoneConfigKeys` conflict introduced by
#10538):
1. **Heartbeat threshold key** — moved to `HddsConfigKeys` following the
`hdds.heartbeat.*` convention: `hdds.heartbeat.address.refresh.threshold`
(`HDDS_HEARTBEAT_ADDRESS_REFRESH_THRESHOLD`). Updated `ozone-default.xml` and
the call sites.
2. **`EndpointStateMachine.resolveLatestAddress`** — a malformed `host:port`
now throws `IllegalStateException("Malformed host address: " + hostAndPort,
ex)` instead of being swallowed.
3. Same method — extract `refreshedIp = refreshed.getAddress()` and
null-check it (warn + keep the previous address) before the equality check, per
your snippet.
On the larger point — keying `scmMachines` (and `StateContext.endpoints`) by
`hostAndPort` instead of `InetSocketAddress`: I agree, that's the right model
and it removes both the re-key dance in `refreshSCMServer` and the collision
check. Since it spans `SCMConnectionManager` + `StateContext` and needs a
decision on the key for endpoints added without a preserved `host:port`
(`addReconServer` and the legacy `addSCMServer` overload pass `hostAndPort =
null` today), I'd prefer to do it as a focused follow-up rather than grow this
PR. Happy to file the JIRA and link it here — let me know if you'd rather fold
it in.
Also fixed my tooling to follow `AGENTS.md` (120-char limit, no early
wrapping) — thanks for the pointer, @ivandika3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
