adoroszlai commented on PR #10488:
URL: https://github.com/apache/ozone/pull/10488#issuecomment-4799034535
> Also fixed my tooling to follow `AGENTS.md` (120-char limit, no early
wrapping)
I think it's still wrapping unnecessarily. Examples:
```java
connectionManager.addSCMServer(scmAddress, hostAndPort,
context.getThreadNamePrefix());
...
EndpointStateMachine endPoint =
buildScmEndpoint(address, hostAndPort, threadNamePrefix);
```
Am I the only one who finds these 10+ line comments annoying? Explaining
motivation for some code is OK, but for every single `ConcurrentHashMap` etc.?
Code references in comments also tend to get outdated soon. Please try to find
a middle ground in verbosity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
