adoroszlai commented on code in PR #10569:
URL: https://github.com/apache/ozone/pull/10569#discussion_r3451484346
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/fs/ozone/OzoneFsShell.java:
##########
@@ -78,12 +78,11 @@ protected String getUsagePrefix() {
public static void main(String[] argv) throws Exception {
OzoneFsShell shell = newShellInstance();
OzoneConfiguration conf = new OzoneConfiguration();
- TracingUtil.initTracing("FsShell", conf);
conf.setQuietMode(false);
shell.setConf(conf);
String spanName = "ozone fs " + String.join(" ", argv);
- int res = TracingUtil.executeInNewSpan(spanName,
- () -> shell.execute(argv));
+ int res = TracingUtil.execute("FsShell", spanName, conf, () ->
shell.execute(argv));
+
Review Comment:
Thanks @sravani-revuri for updating the patch. It looks like reordering
`conf.setQuietMode(false)` here causes `RuntimeException: hdfs-default.xml not
found` in `ozone fs`.
Can you please try moving the two statements into the `supplier` block?
Something like:
```java
int res = TracingUtil.execute("FsShell", spanName, conf, () -> {
conf.setQuietMode(false);
shell.setConf(conf);
return shell.execute(argv);
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
