adoroszlai commented on code in PR #10569:
URL: https://github.com/apache/ozone/pull/10569#discussion_r3465386669
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java:
##########
@@ -95,13 +97,51 @@ public static synchronized void reconfigureTracing(
initTracing(serviceName, tracingConfig);
}
+ /**
+ * Drain the BatchSpanProcessor queue without shutting down.
+ * Call from short-lived CLIs before the JVM exits.
+ */
+ public static synchronized void flushTracing() {
+ if (batchSpanProcessor == null) {
+ return;
+ }
+ try {
+ batchSpanProcessor.forceFlush().join(10, TimeUnit.SECONDS);
Review Comment:
- I think tracing is "best effort", losing some spans is OK. It may even
have sampling enabled, where we intentionally drop most spans.
- Users executing the commands don't care about tracing.
- Logging is OFF by default for CLI commands, so these warnings go to
`/dev/null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
