prathmesh12-coder commented on code in PR #10604:
URL: https://github.com/apache/ozone/pull/10604#discussion_r3536393969


##########
hadoop-ozone/cli-debug/src/main/java/org/apache/hadoop/ozone/debug/replicas/ReplicasVerify.java:
##########
@@ -89,6 +92,18 @@ public class ReplicasVerify extends Handler {
       defaultValue = "1000000")
   private long containerCacheSize;
 
+  @CommandLine.Option(names = {"--out", "-o"},
+      description = "Output directory to dump verification output.The 
directory is created if it does not exist, " +
+          "and files are named using the directory's name as the base, e.g. 
<dirName>.0, <dirName>.1, " +
+          "when splitting with --max-records-per-file (otherwise a single 
<dirName> file is written).")
+  private String outputDir;
+
+  @CommandLine.Option(names = {"--max-records-per-file"},
+      description = "Maximum number of keys to write per output file. When 
greater than zero (and --out is set), " +
+          "output is split into multiple valid JSON files named <out>.0, 
<out>.1, Requires --out.",

Review Comment:
   Thanks @sarvekshayr for review !!
   added validation to ensure `--max-records-per-file` is always being paired 
with `--out`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to