sreejasahithi commented on code in PR #10604:
URL: https://github.com/apache/ozone/pull/10604#discussion_r3541389812
##########
hadoop-ozone/cli-debug/src/main/java/org/apache/hadoop/ozone/debug/replicas/ReplicasVerify.java:
##########
Review Comment:
@prathmesh12-coder on a second thought repeating the top-level pass in
every split file may confuse users who inspect a single chunk as they may treat
it as chunk-level pass/fail rather than the result for the entire run. Since
each key already has pass field split files could stay as { "keys": [...] }
only. A one-line note in the --max-records-per-file help text should be enough.
something like "Split output files do not include a top-level pass field,
check each key's pass."
sorry for the confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
