yandrey321 commented on code in PR #10633:
URL: https://github.com/apache/ozone/pull/10633#discussion_r3546483921


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java:
##########
@@ -218,13 +224,27 @@ protected List< OmKeyLocationInfo > 
allocateBlock(ScmClient scmClient,
       }
       throw ex;
     }
+    // Cache the sorted order by pipeline nodes so blocks whose pipelines have
+    // the same datanodes are sorted once (mirrors the read path's caching).
+    final Map<List<DatanodeDetails>, List<? extends DatanodeDetails>> 
sortedByNodes =

Review Comment:
   Should we use concurrent map? How do we handle concurrent requests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to