chihsuan commented on PR #10633: URL: https://github.com/apache/ozone/pull/10633#issuecomment-4925167581
> If OM side sorting is enabled and the topology cache is unavailable, we already sent an empty clientMachine to SCM, so there is no SCM-side fallback. Is the startup invariant strong enough here, or should `sortDatanodesForWrite` catch missing topology and return the original pipeline @peterxcli OM initializes the topology cache at startup, so a normally running OM should already have it. But your point is valid. With OM-side sorting enabled, SCM-side fallback will not happen. I added a defensive fallback in `sortDatanodesForWrite` to keep the original pipeline order if OM cannot access the topology cache. https://github.com/apache/ozone/pull/10633/commits/914bf1b873dc2e2cf1dc255dfead6b280bff342f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
