Copilot commented on code in PR #10692:
URL: https://github.com/apache/ozone/pull/10692#discussion_r3549584873
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SstFilteringService.java:
##########
@@ -256,6 +260,21 @@ public BackgroundTaskResult call() throws Exception {
}
}
}
+ if (sstFilteringIssued) {
+ // Confirm the physical SST removal outside the bootstrap read
lock
+ // and the open snapshot. On RocksDB 10 a range delete may not
+ // remove the file promptly, so this wait can take up to a
minute;
+ // keeping it out of BOOTSTRAP_LOCK prevents it from starving
the OM
Review Comment:
The comment says the wait "can take up to a minute", but the code may wait
up to 60s per file (and can therefore exceed a minute total when multiple SST
files are returned). Adjust the wording to avoid under-stating the potential
delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
