sadanand48 commented on code in PR #10692:
URL: https://github.com/apache/ozone/pull/10692#discussion_r3550158791
##########
hadoop-hdds/managed-rocksdb/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedRocksDB.java:
##########
@@ -211,7 +218,7 @@ public void deleteSstFileRange(
} catch (RocksDBException e) {
throw new RocksDatabaseException("Failed to delete " + file, e);
}
- ManagedRocksObjectUtils.waitForFileDelete(file, Duration.ofSeconds(60));
+ return file;
Review Comment:
via cursor
> When deleteFilesInRanges successfully removes an SST from the live file
set
([getLiveFilesMetaData()](https://github.com/facebook/rocksdb/wiki/Delete-Stale-Files)),
RocksDB updates the MANIFEST via LogAndApply and then synchronously calls
[PurgeObsoleteFiles()](https://github.com/facebook/rocksdb/blob/v10.10.1/db/db_impl/db_impl.cc#L5007-L5015),
which unlinks table files through
[DeleteDBFile()](https://github.com/facebook/rocksdb/blob/v10.10.1/db/db_impl/db_impl_files.cc#L377-L385)
before the API returns — the same path [documented as immediately reclaiming
space](https://github.com/facebook/rocksdb/wiki/Delete-A-Range-Of-Keys)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
