chihsuan commented on PR #10633: URL: https://github.com/apache/ozone/pull/10633#issuecomment-4935871498
Thanks for the detailed review! @szetszwo I merged the latest master to build on the #10701 (HDDS-15803) refactor and applied the proposed changes: - Added SCM fallback when the OM topology cache is unavailable. - Added the nullable topology accessor while preserving the strict `OzoneManager#getClusterMap()` contract. - Removed the `NullPointerException` catch from `KeyManagerImpl`. - Added a unit test for the fallback path. The only difference from the suggested snippet is the condition for OM-side sorting: it checks that OM sorting is enabled and the topology is available. This preserves the configuration semantics. Otherwise, sorting falls back to SCM. I've also addressed all the Copilot review comments. When you have a chance, could you please take another look? Thank you! 🙇♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
