chihsuan commented on code in PR #10695:
URL: https://github.com/apache/ozone/pull/10695#discussion_r3562875137
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TraceAllMethod.java:
##########
@@ -77,7 +78,13 @@ public Object invoke(Object proxy, Method method, Object[]
args)
}
}
- try (TracingUtil.TraceCloseable ignored =
TracingUtil.createActivatedSpan(name + "." + method.getName())) {
+ // close() is local cleanup in the shell process, not an outbound RPC to
OM/SCM/DN , so it stays INTERNAL.
+ SpanKind spanKind = "close".equals(method.getName())
Review Comment:
Thanks for adding the comment. @sravani-revuri Just thinking a bit more on
this, is `close` the only local method here?
It looks like `getS3CredentialsProvider()` just returns a `ThreadLocal`
with no RPC, yet it'd still read as `CLIENT`. Should we avoid inferring the
span kind from the method name here? Would a method-level override/annotation
for local operations be more robust while keeping remote protocol methods
`CLIENT` by default? curious what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
