sravani-revuri commented on code in PR #10695:
URL: https://github.com/apache/ozone/pull/10695#discussion_r3563373440
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TraceAllMethod.java:
##########
@@ -77,7 +78,13 @@ public Object invoke(Object proxy, Method method, Object[]
args)
}
}
- try (TracingUtil.TraceCloseable ignored =
TracingUtil.createActivatedSpan(name + "." + method.getName())) {
+ // close() is local cleanup in the shell process, not an outbound RPC to
OM/SCM/DN , so it stays INTERNAL.
+ SpanKind spanKind = "close".equals(method.getName())
Review Comment:
Thanks for pointing that out @chihsuan ! Implementing an annotation is a
much cleaner and more extensible approach for this.
I have added `@InternalSpanKind` to handle the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
