sreejasahithi commented on PR #10699: URL: https://github.com/apache/ozone/pull/10699#issuecomment-4971687252
> Yeah, I agree. I considered returning a non-zero value, but the existing `OMNodeDetails` validation returns exit code 0, so I kept the new validation consistent. I can change it in this PR if you prefer; otherwise, we can address exit codes consistently in a follow-up. What do you think? I am fine tracking consistent non zero exit codes in a follow up Jira if you want to keep this PR scoped for fail fast fix for missing --node-id. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
