Gargi-jais11 commented on code in PR #10609:
URL: https://github.com/apache/ozone/pull/10609#discussion_r3584985161
##########
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - Disk
Balancer.json:
##########
@@ -0,0 +1,358 @@
+{
+ "annotations": {
+ "list": [
+ {
+ "builtIn": true,
+ "enable": true,
+ "hide": true,
+ "name": "Annotations & Alerts",
+ "type": "dashboard"
+ }
+ ]
+ },
+ "editable": true,
+ "fiscalYearStartMonth": 0,
+ "graphTooltip": 1,
+ "id": null,
+ "links": [],
+ "liveNow": false,
+ "panels": [
+ {
+ "id": 2,
+ "title": "Disk Space Convergence Profile (Historical Before vs After)",
+ "type": "timeseries",
+ "description": "Shows how full each disk is over time. When the balancer
is running, you should see these lines slowly move closer together until they
meet in the middle.",
+ "gridPos": { "x": 0, "y": 0, "w": 12, "h": 7 },
+ "datasource": { "type": "prometheus", "uid": "${datasource}" },
+ "targets": [
+ {
+ "expr": "sum({__name__=~\"volume_info_metrics_.*_ozone_used\",
instance=~\"$datanode.*\"}) by (instance, storagedirectory)",
Review Comment:
```suggestion
"expr": "sum({__name__=~\"volume_info_metrics_.*_ozone_used\",
instance=~\"$datanode\"}) by (instance, storagedirectory)",
```
There are 13 occurances of this, please fix it.
In regex, .* binds only to the last alternative. So:
```
ozone-datanode-1:9882 — matched exactly (no suffix allowed)
ozone-datanode-2:9882.* — matched with optional trailing chars
```
The first datanode can fail to match depending on the exact instance label.
That is why multi-select filtering is unreliable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
