Gargi-jais11 commented on code in PR #10609:
URL: https://github.com/apache/ozone/pull/10609#discussion_r3584994221


##########
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - Disk 
Balancer.json:
##########
@@ -0,0 +1,358 @@
+{
+  "annotations": {
+    "list": [
+      {
+        "builtIn": true,
+        "enable": true,
+        "hide": true,
+        "name": "Annotations & Alerts",
+        "type": "dashboard"
+      }
+    ]
+  },
+  "editable": true,
+  "fiscalYearStartMonth": 0,
+  "graphTooltip": 1,
+  "id": null,
+  "links": [],
+  "liveNow": false,
+  "panels": [
+    {
+      "id": 2,
+      "title": "Disk Space Convergence Profile (Historical Before vs After)",
+      "type": "timeseries",
+      "description": "Shows how full each disk is over time. When the balancer 
is running, you should see these lines slowly move closer together until they 
meet in the middle.",
+      "gridPos": { "x": 0, "y": 0, "w": 12, "h": 7 },
+      "datasource": { "type": "prometheus", "uid": "${datasource}" },
+      "targets": [
+        {
+          "expr": "sum({__name__=~\"volume_info_metrics_.*_ozone_used\", 
instance=~\"$datanode.*\"}) by (instance, storagedirectory)",
+          "legendFormat": "{{storagedirectory}}",
+          "refId": "A"
+        }
+      ],
+      "fieldConfig": {
+        "defaults": {
+          "unit": "decbytes",
+          "color": { "mode": "palette-classic" },
+          "custom": {
+            "drawStyle": "line",
+            "lineInterpolation": "smooth",
+            "lineWidth": 2
+          }
+        }
+      }
+    },
+    {
+      "id": 3,
+      "title": "Current Disk Space Allocation Skew (Max - Min Volume Gap)",
+      "type": "bargauge",
+      "description": "The exact size of the data gap between your most full 
disk and your emptiest disk right now. The balancer's goal is to shrink this 
number down to zero.",
+      "gridPos": { "x": 12, "y": 0, "w": 12, "h": 7 },
+      "datasource": { "type": "prometheus", "uid": "${datasource}" },
+      "targets": [
+        {
+          "expr": "max(sum({__name__=~\"volume_info_metrics_.*_ozone_used\", 
instance=~\"$datanode.*\"}) by (instance, storagedirectory)) by (instance) - 
min(sum({__name__=~\"volume_info_metrics_.*_ozone_used\", 
instance=~\"$datanode.*\"}) by (instance, storagedirectory)) by (instance)",
+          "instant": true,
+          "refId": "A"
+        }
+      ],
+      "fieldConfig": {
+        "defaults": {
+          "unit": "decbytes",
+          "max": 5368709120

Review Comment:
   Remove the hardcoded max so Grafana auto-scales to the actual data range. 
For production cluster 5GB of difference between the max utilised and min 
utilised disk doesn't make sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to