jojochuang commented on PR #10741: URL: https://github.com/apache/ozone/pull/10741#issuecomment-4984050254
I think other than the omitted headOp in ClientProtocol.getOzoneFileStatus(), the rest are mostly good. As a follow up item, We can check other usage of FileStatus.isDirectory() and FileStatus.isFile(), and if the file status is only used to check if its file or directory, update them to include headOp. For example: https://github.com/apache/ozone/blob/f41cd8e0a098b1ecbf2d1f4d0c1ad00e98e7a19a/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java#L1902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
