jojochuang commented on PR #10741: URL: https://github.com/apache/ozone/pull/10741#issuecomment-4985809621
LGTM --- A few more for follow-up: Candidate | Only type-checked? | Head-op API available? | Effort -- | -- | -- | -- BasicOzoneFileSystem.isDirectory/isFile (o3fs) | Yes | No — needs adapter plumbing | Medium (mirror the PR for o3fs) DeleteKeyHandler L103, L125 | Yes | Yes (OzoneBucket.getFileStatus(k, headOp)) | Trivial BasicOzoneFileSystem L787 (trash) | Yes | Only via getFileStatusAdapter(p,true) | Small BasicRootedOzoneClientAdapterImpl L764 (trash) | First call yes (2nd keeps status) | Via adapter | Small <p style="font-size: 16px; margin: 0px 1em 1rem; padding: 0px; font-weight: 400; color: rgb(31, 35, 40); font-family: -apple-system, "system-ui", "Segoe UI", "Noto Sans", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: normal; text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;">The two clearly worth doing are the<span> </span><strong style="font-weight: 600;">o3fs<span> </span><code style="font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 13.6px; padding: 0.2em 0.4em; margin: 0px; white-space: break-spaces; background-color: rgba(129, 1 39, 152, 0.12); border-radius: 6px;">isDirectory</code>/<code style="font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 13.6px; padding: 0.2em 0.4em; margin: 0px; white-space: break-spaces; background-color: rgba(129, 139, 152, 0.12); border-radius: 6px;">isFile</code></strong><span> </span>(consistency with this PR's whole point) and<span> </span><strong style="font-weight: 600;"><code style="font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 13.6px; padding: 0.2em 0.4em; margin: 0px; white-space: break-spaces; background-color: rgba(129, 139, 152, 0.12); border-radius: 6px;">DeleteKeyHandler</code></strong><span> </span>(free win, API already exists).</p> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
