ChenSammi commented on a change in pull request #2382:
URL: https://github.com/apache/ozone/pull/2382#discussion_r667736620
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java
##########
@@ -1028,6 +1047,8 @@ private void sendReplicateCommand(final ContainerInfo
container,
LOG.info("Sending replicate container command for container {}" +
" to datanode {} from datanodes {}",
container.containerID(), datanode, sources);
+ metrics.incrNumReplicateCmdsSent();
Review comment:
Suggest to move the metrics operation after the command is sent.
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java
##########
@@ -1051,6 +1072,7 @@ private void sendDeleteCommand(final ContainerInfo
container,
LOG.info("Sending delete container command for container {}" +
" to datanode {}", container.containerID(), datanode);
+ metrics.incrNumDeleteCmdsSent();
Review comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
