ChenSammi commented on pull request #2382: URL: https://github.com/apache/ozone/pull/2382#issuecomment-878095230
Thanks @guihecheng for working on this. I just left a few comments. Hi @sodonnel, would you help to have a look at this patch? There are two changes to the ReplicationManager metrics. One is the metrics name changing from INFLIGHT_REPLICATION to inflightReplication, another is the metrics source name changing from ReplicationManager to ReplicationManagerMetrics. Though I think the new names are more consistent with current other module metrics style, we would like to have your thoughts here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
