[
https://issues.apache.org/jira/browse/HDDS-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18097951#comment-18097951
]
arun kumar commented on HDDS-15858:
-----------------------------------
Thanks for confirming the approach and the base branch.
On the Prometheus scrape side, I found a deeper gap and want to check the
intended scope before coding:
- httpfs is not in compose/ozone/prometheus.yml or the *monitoring-config
anchor in compose/ozone/monitoring.yaml.
- Adding the scrape target alone won't be enough — HttpFSServerWebServer builds
an HttpServer2 directly (does not extend BaseHttpServer), so it currently has
no /prom endpoint. BaseHttpServer wires the PrometheusServlet and
PrometheusMetricsSink; httpfs skips that path, so Prometheus scraping /prom on
port 14000 today would 404.
Two ways this can go:
1. Same PR: wire PrometheusServlet + PrometheusMetricsSink into
HttpFSServerWebServer (mirroring BaseHttpServer.buildBaseHttpServer lines
156-176), then add httpfs:14000 to prometheus.yml and the *monitoring-config
anchor. About +30-40 lines.
2. Follow-up JIRA: land the current 3-line BuildInfoMetrics wiring now (already
pushed to my fork branch HDDS-15858-httpfs-zdu-dashboard), file a follow-up for
the /prom endpoint + scrape config so ozone_build_info actually reaches
Prometheus.
Slight preference for (1) since without a /prom endpoint the metric is
effectively unreachable, but (2) keeps the diffs cleaner. Happy to go either
way — let me know which fits better.
> Add Httpfs gateway to ZDU dashboard
> -----------------------------------
>
> Key: HDDS-15858
> URL: https://issues.apache.org/jira/browse/HDDS-15858
> Project: Apache Ozone
> Issue Type: Improvement
> Reporter: Ethan Rose
> Assignee: arun kumar
> Priority: Major
>
> Build on HDDS-14825 to add metrics and tracking for httpfs gateway during a
> rolling upgrade.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
