ChenSammi commented on a change in pull request #2354:
URL: https://github.com/apache/ozone/pull/2354#discussion_r669362019
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java
##########
@@ -196,7 +200,7 @@ public boolean hasEnoughSpace(DatanodeDetails
datanodeDetails,
for (MetadataStorageReportProto reportProto
: datanodeInfo.getMetadataStorageReports()) {
- if (reportProto.getRemaining() > metaSizeRequired) {
+ if (reportProto.getRemaining() > metadataSizeRequired) {
Review comment:
Can you add a “metadataSizeRequired not 0" if check around this for
loop? since metadataSizeRequired is passed as 0 in container replication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
