[ 
https://issues.apache.org/jira/browse/HDDS-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18100250#comment-18100250
 ] 

yangminglin commented on HDDS-10478:
------------------------------------

Hi, I'd like to work on this issue. I checked the current master branch, and 
{{MockDatanodeStorage}} still stores {{fullBlockData}} as {{{}String{}}}. I 
plan to change it to {{ByteString}} and update the related assertions in 
{{TestOzoneECClient}} to compare the exact binary data. Is this approach still 
desired?

> fullBlockData map value in MockDatanodeStorage should ideally hold ByteString
> -----------------------------------------------------------------------------
>
>                 Key: HDDS-10478
>                 URL: https://issues.apache.org/jira/browse/HDDS-10478
>             Project: Apache Ozone
>          Issue Type: Bug
>          Components: test
>            Reporter: Siyao Meng
>            Priority: Major
>
> Credit: [~weichiu]
> fullBlockData map value in MockDatanodeStorage should ideally hold ByteString 
> rather than String. The idea is that it should hold the same type as {{data}}:
> {code:java}
>   private final Map<BlockID, String> fullBlockData = new HashMap<>();
>   private final Map<String, ChunkInfo> chunks = new HashMap<>();
>   private final Map<String, ByteString> data = new HashMap<>();
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to