dombizita commented on code in PR #10902:
URL: https://github.com/apache/ozone/pull/10902#discussion_r3690658609
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -1224,13 +1224,23 @@ public HddsProtos.UpgradeStatus queryUpgradeStatus()
throws IOException {
scm.getScmNodeManager().getDatanodeFinalizationCounts();
int finalizedDatanodes =
datanodeFinalizationCounts.getNumFinalizedDatanodes();
int healthyDatanodes =
datanodeFinalizationCounts.getTotalHealthyDatanodes();
- boolean hddsFinalized = scmFinalized &&
datanodeFinalizationCounts.allNodesFinalized();
+
+ HddsProtos.FinalizationStatus scmFinalizationStatus =
+ scmFinalized ? HddsProtos.FinalizationStatus.FINALIZED :
HddsProtos.FinalizationStatus.UNFINALIZED;
Review Comment:
SCM can only be either `FINALIZED` or `UNFINALIZED`?
##########
hadoop-ozone/cli-admin/src/test/java/org/apache/hadoop/ozone/admin/upgrade/TestFinalizeSubCommand.java:
##########
@@ -297,10 +297,10 @@ public void testWaitFlagWithVerbosePrintsFullStatus()
throws Exception {
private static QueryUpgradeStatusResponse inProgressStatus(int dnFinalized,
int dnTotal) {
return QueryUpgradeStatusResponse.newBuilder()
- .setOmFinalized(false)
- .setClusterFinalized(false)
+ .setOmFinalizationStatus(HddsProtos.FinalizationStatus.UNFINALIZED)
Review Comment:
Isn't this supposed to be `IN_PROGRESS`? Or the cluster status `UNFINALIZED`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
